login  home  contents  what's new  discussion  bug reports     help  links  subscribe  changes  refresh  edit

Edit detail for #351 interpreter crash factoring 1+2%i in COMPLEX PF 5 revision 3 of 3

1 2 3
Editor: kratt6
Time: 2007/12/20 00:14:02 GMT-8
Note:

added:

From kratt6 Thu Dec 20 00:14:02 -0800 2007
From: kratt6
Date: Thu, 20 Dec 2007 00:14:02 -0800
Subject: 
Message-ID: <20071220001402-0800@axiom-wiki.newsynthesis.org>

Status: open => fix proposed 


Submitted by : (unknown) at: 2007-11-17T22:31:42-08:00 (17 years ago)
Name :
Axiom Version :
Category : Severity : Status :
Optional subject :  
Optional comment :

In wh-sandbox, revision 506, the following line crashes the interpreter. In fact, it seems that other versions don't like it either.


[(random()$COMPLEX PF 5)::FR COMPLEX PF 5 for i in 1..10]

The expected behaviour is not to call factor at all, since Complex PF 5 is a field. NO! Only Axiom believes it is a field, see issue #354. Apart from that, Waldek suggested to modify Factored as follows:

         if R has UniqueFactorizationDomain
           then
             coerce(r:R):% ==
               zero? r => 0
               unit? r => mkFF(r, empty())
               if R has Field => error "zero divisor in a field"
               unitNormalize(squareFree(r) pretend %)

make name more precise --kratt6, Sat, 28 Apr 2007 16:17:36 -0500 reply
Name: #351 interpreter crash => #351 interpreter crash factoring 1+2%i in COMPLEX PF 5

workaround implemented in FriCAS --kratt6, Thu, 20 Dec 2007 00:13:52 -0800 reply
The suggested workaround has been implemented in FriCAS. However, Complex PF 5 is still a field there, since conditional exports are implemented only very superficially.

Martin

Status: open => fix proposed