help links subscribe changes refresh edit

	IssueTracker
#40 broken input file testing ←	↑	→ #402 binary for fedora core 6

#401 unparse generates Fortran function names

Edit detail for #401 unparse generates Fortran function names revision 9 of 9

	1 2 3 4 5 6 7 8 9
Editor: Bill Page Time: 2008/09/16 20:34:12 GMT-7
Note: Waldek's patch to format.boot

added:

From BillPage Tue Sep 16 20:34:11 -0700 2008
From: Bill Page
Date: Tue, 16 Sep 2008 20:34:11 -0700
Subject: Waldek's patch to format.boot
Message-ID: <20080916203411-0700@axiom-wiki.newsynthesis.org>

SandBoxUnparse

In an email with subject:

  Axiom: Printing multiple variables in axiom.

to axiom-math on Nov 11, 2007 3:10 PM Constantine Frangos reported that:

I am getting the result below for y.

However, the output I actually want is:

  "cos(x2) + 2*x1"

or even better:

  cos(x2) + 2*x1

Is this possible ?

fricas

y := cos(x2) + 2*x1

$\label{eq1}{\cos \left({x 2}\right)}+{2 \ x 1}$

(1)

Type: Expression(Integer)

fricas

unparse(y::INFORM)

$\label{eq2}\mbox{\tt "cos(x2)+2<em>x1"}$

(2)

Type: String

I think the problem originats in the routine form2String1 which is called via form2String from unparse. form2String1 calls fortexp0 defined in newfort.boot. This routine calls expression2Fortran which transforms the InputForm via:

  fortranCleanUp exp2Fort1 segment fortPre exp2FortOptimize outputTran e

fortPre is responsible for renaming functions like cos to DCOS for Fortran double or single float compatibility in a routine called mkFortFn. segment is intended to handle lines longer than allowed in Fortran, and outputTran renames some operations to be subsequently remapped by fortPre to the appropriate operator depending on the precision setting. None of this is necessary if the intention is to "unparse" an Axiom expression.

The patch to format.boot below avoids this problem.

boot

form2String1 u ==
  ATOM u => 
    u=$EmptyMode or u=$quadSymbol => formWrapId specialChar 'quad
    IDENTP u =>
      constructor? u => app2StringWrap(formWrapId u, [u])
      u
    SUBRP u => formWrapId BPINAME u
    STRINGP u => formWrapId u
    WRITE_-TO_-STRING formWrapId u
  u1 := u
  op := CAR u
  argl := CDR u
  op='Join or op= 'mkCategory => formJoin1(op,argl)
  $InteractiveMode and (u:= constructor? op) =>
    null argl => app2StringWrap(formWrapId constructorName op, u1)
    op = "NTuple"  => [ form2String1 first argl, "*"]
    op = "Map"     => ["(",:formatSignature0 [argl.1,argl.0],")"]
    op = 'Record => record2String(argl)
    null (conSig := getConstructorSignature op) =>
      application2String(constructorName op,[form2String1(a) for a in argl], u1)
    ml := rest conSig
    if not freeOfSharpVars ml then
      ml:=SUBLIS([[pvar,:val] for pvar in $FormalMapVariableList
        for val in argl], ml)
    argl:= formArguments2String(argl,ml)
      -- extra null check to handle mutable domain hack.
    null argl => constructorName op
    application2String(constructorName op,argl, u1)
  op = "Mapping" => ["(",:formatSignature argl,")"]
  op = "Record" => record2String(argl)
  op = 'Union  =>
    application2String(op,[form2String1 x for x in argl], u1)
  op = ":" =>
      null argl => [ '":" ]
      null rest argl => [ '":", form2String1 first argl ]
      formDecl2String(argl.0,argl.1)
  op = "#" and PAIRP argl and LISTP CAR argl =>
    STRINGIMAGE SIZE CAR argl
  op = 'Join => formJoin2String argl
  op = "ATTRIBUTE" => form2String1 first argl
  op='Zero => 0
  op='One => 1
  op = 'AGGLST => tuple2String argl
  op = 'BRACKET =>
    argl' := form2String1 first argl
    ["[",:(atom argl' => [argl']; argl'),"]"]
  op = "SIGNATURE" =>
     [operation,sig] := argl
     concat(operation,": ",formatSignature sig)
  op = 'COLLECT => formCollect2String argl
  op = 'construct =>
    concat(lbrkSch(),
           tuple2String [form2String1 x for x in argl],rbrkSch())
  op = "SEGMENT" =>
    null argl => '".."
    lo := form2String1 first argl
    argl := rest argl
    (null argl) or null (first argl) => [lo, '".."]
    [lo, '"..", form2String1 first argl]
  --isBinaryInfix op => fortexp0 [op,:argl]
  fortranCleanUp exp2Fort1 exp2FortOptimize [op,:argl]
  -- COMPILED_-FUNCTION_-P(op) => form2String1 coerceMap2E(u1,NIL)
  --application2String(op,[form2String1 x for x in argl], u1)

boot

 
   >> System error:
   invalid number of arguments: 1

; compiling file "/var/aw/var/LatexWiki/904736018644071145-25px002.clisp" (written 17 MAR 2011 10:05:58 AM):

; /var/aw/var/LatexWiki/904736018644071145-25px002.fasl written
; compilation finished in 0:00:00.020
Value = T

The function:

  parse(s)==interpret(ncParseFromString(s)$Lisp::INFORM)

parses abd evaluates a string s, returning the result as ANY. We can use this to test that unparse

fricas

parse(s)==interpret(ncParseFromString(s)$Lisp::INFORM)

   >> System error:
   The function BOOT::BOOT-EQUAL is undefined.

same problem occurs in graphics --page, Mon, 12 Nov 2007 18:25:31 -0800 reply

The display of function names in legends generated by Axiom graphics also suffers from Fortranish names like DSIN etc. The patch to format.boot above also fixes that.

... --kratt6, Mon, 24 Dec 2007 05:35:45 -0800 reply

Status: open => fix proposed

The patch to format.boot below avoids this problem.

On Tue, Sep 2, 2008 at 6:34 PM, Waldek Hebisch wrote:

So I propose to apply a variation of Bill's patch. Compared to Bill I am using Fortran machinery only for binary operators (like current code). Also, I am setting a few variables used by Fortran machinery - I do not have a testcase, but I expect that on complicated expressions Fortran machinery will fail if those variables have no value.

Patch:

  diff -ru --exclude=.svn trunk.bb/src/interp/format.boot trunk/src/interp/format.boot
  --- trunk.bb/src/interp/format.boot     2008-09-03 00:06:07.000000000 +0200
  +++ trunk/src/interp/format.boot        2008-09-03 00:07:38.000000000 +0200
  @@ -428,10 +428,15 @@
      argl := rest argl
      (null argl) or null (first argl) => [lo, '".."]
      [lo, '"..", form2String1 first argl]
  -  isBinaryInfix op => fortexp0 [op,:argl]
  -  -- COMPILED_-FUNCTION_-P(op) => form2String1 coerceMap2E(u1,NIL)
  +  isBinaryInfix op => binop2String [op,:argl]
    application2String(op,[form2String1 x for x in argl], u1)

  +binop2String x ==
  +    $exp2FortTempVarIndex : local := 0
  +    $fortName : fluid := newFortranTempVar()
  +    $fortInts2Floats : fluid := nil
  +    fortranCleanUp exp2Fort1 exp2FortOptimize x
  +
   formWrapId id ==
    $formatSigAsTeX = 1 => id
    $formatSigAsTeX = 2 =>

----

boot

form2String1 u ==
  ATOM u => 
    u=$EmptyMode or u=$quadSymbol => formWrapId specialChar 'quad
    IDENTP u =>
      constructor? u => app2StringWrap(formWrapId u, [u])
      u
    SUBRP u => formWrapId BPINAME u
    STRINGP u => formWrapId u
    WRITE_-TO_-STRING formWrapId u
  u1 := u
  op := CAR u
  argl := CDR u
  op='Join or op= 'mkCategory => formJoin1(op,argl)
  $InteractiveMode and (u:= constructor? op) =>
    null argl => app2StringWrap(formWrapId constructorName op, u1)
    op = "NTuple"  => [ form2String1 first argl, "*"]
    op = "Map"     => ["(",:formatSignature0 [argl.1,argl.0],")"]
    op = 'Record => record2String(argl)
    null (conSig := getConstructorSignature op) =>
      application2String(constructorName op,[form2String1(a) for a in argl], u1)
    ml := rest conSig
    if not freeOfSharpVars ml then
      ml:=SUBLIS([[pvar,:val] for pvar in $FormalMapVariableList
        for val in argl], ml)
    argl:= formArguments2String(argl,ml)
      -- extra null check to handle mutable domain hack.
    null argl => constructorName op
    application2String(constructorName op,argl, u1)
  op = "Mapping" => ["(",:formatSignature argl,")"]
  op = "Record" => record2String(argl)
  op = 'Union  =>
    application2String(op,[form2String1 x for x in argl], u1)
  op = ":" =>
      null argl => [ '":" ]
      null rest argl => [ '":", form2String1 first argl ]
      formDecl2String(argl.0,argl.1)
  op = "#" and PAIRP argl and LISTP CAR argl =>
    STRINGIMAGE SIZE CAR argl
  op = 'Join => formJoin2String argl
  op = "ATTRIBUTE" => form2String1 first argl
  op='Zero => 0
  op='One => 1
  op = 'AGGLST => tuple2String argl
  op = 'BRACKET =>
    argl' := form2String1 first argl
    ["[",:(atom argl' => [argl']; argl'),"]"]
  op = "SIGNATURE" =>
     [operation,sig] := argl
     concat(operation,": ",formatSignature sig)
  op = 'COLLECT => formCollect2String argl
  op = 'construct =>
    concat(lbrkSch(),
           tuple2String [form2String1 x for x in argl],rbrkSch())
  op = "SEGMENT" =>
    null argl => '".."
    lo := form2String1 first argl
    argl := rest argl
    (null argl) or null (first argl) => [lo, '".."]
    [lo, '"..", form2String1 first argl]
    isBinaryInfix op => binop2String [op,:argl]
    application2String(op,[form2String1 x for x in argl], u1)

binop2String x ==
    $exp2FortTempVarIndex : local := 0
    $fortName : fluid := newFortranTempVar()
    $fortInts2Floats : fluid := nil
    fortranCleanUp exp2Fort1 exp2FortOptimize x

boot

 
   >> System error:
   invalid number of arguments: 1

; compiling file "/var/aw/var/LatexWiki/6774118422206085966-25px004.clisp" (written 17 MAR 2011 10:05:59 AM):

; /var/aw/var/LatexWiki/6774118422206085966-25px004.fasl written
; compilation finished in 0:00:00.019
Value = T

Let's try it ...

fricas

y := cos(x2) + 2*x1

$\label{eq3}{\cos \left({x 2}\right)}+{2 \ x 1}$

(3)

fricas

>> System error:
   The function BOOT::BOOT-EQUAL is undefined.

Did I do something wrong in applying the patch?

Waldek's patch to format.boot --Bill Page, Tue, 16 Sep 2008 20:34:11 -0700 reply

SandBoxUnparse